shmup/mud
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Move GMCP/MSDP offers to initial negotiation

Browse source 
The old begin_advanced_negotiation relied on a telnetlib3 hook that races with the negotiation timer — by the time it fires, the timer has already declared negotiation complete. Moving to begin_negotiation sends the offers alongside standard options (TTYPE, NAWS, ECHO) so clients see them immediately.
This commit is contained in:
Jared Miller 2026-02-12 14:36:25 -05:00
parent 05b377f00a
commit aafdcdca42
Signed by: shmup
GPG key ID: 22B5C6D66A38B06C
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/mudlib/server.py
View file

@ -229,9 +229,9 @@ async def handle_login(
class MudTelnetServer(TelnetServer): class MudTelnetServer(TelnetServer):
"""Telnet server that offers GMCP and MSDP during negotiation.""" """Telnet server that offers GMCP and MSDP during negotiation."""
def begin_advanced_negotiation(self) -> None: def begin_negotiation(self) -> None:
"""Offer GMCP and MSDP alongside the standard options.""" """Offer GMCP and MSDP as part of initial negotiation."""
super().begin_advanced_negotiation() super().begin_negotiation()
assert self.writer is not None assert self.writer is not None
gmcp_ok = self.writer.iac(WILL, GMCP) gmcp_ok = self.writer.iac(WILL, GMCP)
msdp_ok = self.writer.iac(WILL, MSDP) msdp_ok = self.writer.iac(WILL, MSDP)