shmup/colabbd
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Make session cleanup atomic in leave()

Browse source
This commit is contained in:
Jared Miller 2026-01-27 17:59:49 -05:00
parent 2de33370cd
commit 8ce1e098e6
Signed by: shmup
GPG key ID: 22B5C6D66A38B06C
2 changed files with 5 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/index.ts
View file

@ -1,10 +1,5 @@
import { decode } from "./protocol"; import { decode } from "./protocol";
import { import { type Client, getOrCreateSession, getSession } from "./session";
type Client,
getOrCreateSession,
getSession,
removeSession,
} from "./session";
const PORT = Number(process.env.PORT) || 4040; const PORT = Number(process.env.PORT) || 4040;
@ -66,7 +61,6 @@ Bun.serve({
if (ws.data.room) { if (ws.data.room) {
const session = getSession(ws.data.room); const session = getSession(ws.data.room);
session?.leave(client); session?.leave(client);
removeSession(ws.data.room);
ws.data.room = null; ws.data.room = null;
} }
break; break;
@ -84,7 +78,6 @@ Bun.serve({
if (ws.data.room && ws.data.client) { if (ws.data.room && ws.data.client) {
const session = getSession(ws.data.room); const session = getSession(ws.data.room);
session?.leave(ws.data.client); session?.leave(ws.data.client);
removeSession(ws.data.room);
} }
console.debug("client disconnected"); console.debug("client disconnected");
}, },

4
src/session.ts
View file

@ -31,6 +31,10 @@ export class Session {
leave(client: Client) { leave(client: Client) {
this.clients.delete(client); this.clients.delete(client);
this.broadcastPeerCount(); this.broadcastPeerCount();
if (this.isEmpty()) {
sessions.delete(this.name);
console.debug(`session removed: ${this.name}`);
}
} }
isEmpty(): boolean { isEmpty(): boolean {